-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Glyphicons to _data, generate Glyphicons markup #11930
Conversation
This generates a glyphicons.yml file from the glyphicons.less source, and then components.html uses that data to generate the Glyphicons docs by iterating through the data. The _data directory was introduced in Jekyll 1.3.0, and GitHub Pages is already on [version 1.4.2][1]. Fixes #11862. [1] https://github.com/github/pages-gem/blob/master/github-pages.gemspec#L16
Could you parse it from |
Aha, I didn't realize that. I will update to use the SVG. |
@cvrebert, the SVG doesn't contain the class names, which is what this page needs. Were those added to |
Actually, they were parsed from http://glyphicons.com , with some manual editing because Bootstrap changes a handful of the names. I guess the LESS approach will have to do. |
We do? |
Yup:
And then there are a bunch where we merely replace underscores with dashes:
|
Ah, this was probably a legacy thing honestly. We had written CSS for them before they were icon fonts. As for underscores, fuck those 😁. |
Write Glyphicons to _data, generate Glyphicons markup
Thanks, @ssorallen! |
This generates a glyphicons.yml file from the glyphicons.less source,
and then components.html uses that data to generate the Glyphicons docs
by iterating through the data. The _data directory was introduced in
Jekyll 1.3.0, and GitHub Pages is already on [version 1.4.2][1].
Fixes #11862.
[1] https://github.com/github/pages-gem/blob/master/github-pages.gemspec#L16