Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant :-moz-placeholder styles #12502

Merged
merged 1 commit into from Feb 7, 2014
Merged

Remove redundant :-moz-placeholder styles #12502

merged 1 commit into from Feb 7, 2014

Conversation

zlatanvasovic
Copy link
Contributor

No need for old Firefox versions support.

No need for old Firefox versions support.
@XhmikosR
Copy link
Member

XhmikosR commented Feb 4, 2014

Err why is that? I mean, it's fine and all moving forward, but people use the framework in production environments where the users don't always update to the latest versions of the browsers. And just having an extra line isn't so big deal.

@cvrebert @mdo: what are the official supported browsers?

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 4, 2014

@XhmikosR Read the Getting Started page of the docs for that

@XhmikosR
Copy link
Member

XhmikosR commented Feb 4, 2014

Well I saw that, but it just says "the latest versions". Which is sort of general.

Anyway, my opinion is since Bootstrap is used very widely, older browsers support should be removed only when there is real gain from that. Removing a line doesn't seem like a real gain to me, but if this is already the case, i.e. no older FF support, then this PR makes sense consistency-wise.

@zlatanvasovic
Copy link
Contributor Author

This is just to keep Bootstrap up-to-date with browser changes, nothing more.

@XhmikosR
Copy link
Member

XhmikosR commented Feb 6, 2014

I believe this can be merged too since Firefox 4 does not seem to be supported. Should I merge it @cvrebert?

@zlatanvasovic
Copy link
Contributor Author

Yes.

2014-02-06 19:59 GMT+01:00 XhmikosR notifications@github.com:

I believe this can be merged too since Firefox 4 does not seem to be
supported.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12502#issuecomment-34356843
.

Zlatan Vasović - ZDroid

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 6, 2014

I'd wait for @mdo's input on this.

mdo added a commit that referenced this pull request Feb 7, 2014
Remove redundant :-moz-placeholder styles
@mdo mdo merged commit 42d7479 into twbs:master Feb 7, 2014
@mdo mdo mentioned this pull request Feb 7, 2014
1 task
stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
Remove redundant :-moz-placeholder styles
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Remove redundant :-moz-placeholder styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants