Carousel event properties #13396
Merged
Carousel event properties #13396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prolly just need @fat's okay on this one. |
| @@ -119,6 +120,7 @@ | |||
| }) | |||
| } | |||
|
|
|||
| var slidEvent = $.Event('slid.bs.carousel', { relatedTarget: relatedTarget, direction: direction }) // yes, "slid". not a typo. past tense of "to slide". | |||
There was a problem hiding this comment.
could you simplify this comment to just: yes, "slid".
There was a problem hiding this comment.
actually no slidEvent is better, maybe change e above to be slideEvent
There was a problem hiding this comment.
and the var names will be enough to ditch all the comments?
|
lgtm basically, just some small thoughts |
|
Okay, made the changes. Will merge once Travis turns green. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13393 & #13395.