Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bootstrap.less from bower main property #13617

Closed
wants to merge 1 commit into from
Closed

Removed bootstrap.less from bower main property #13617

wants to merge 1 commit into from

Conversation

choffmeister
Copy link

As state at https://github.com/bower/bower.json-spec#main bower's main
property should contain only the compiled versions.

As state at https://github.com/bower/bower.json-spec#main bower's main
property should contain only the compiled versions.
@cvrebert
Copy link
Collaborator

See #13328.

@cvrebert
Copy link
Collaborator

Due to lack of progress on that spec (particularly with regard to main; see bower/bower#935), it has unfortunately in practice become no longer controlling, and a few differing emergent conventions for main are now duking it out. Very disappointing, but true.

Is the presence of bootstrap.less causing any concrete issue for you?

@choffmeister
Copy link
Author

No, I have no conrete issues. Just thought it would increase compatibility with the spec. But when the spec is out of date, then this PR is pointless. Also I see the argument, that having to much files in the 'main' property is better than having to less, since the unnecessary files can be filtered out by the build tools...

@juriejan
Copy link

juriejan commented Dec 3, 2014

I would actually benefit from the entire less directory being included in main. The bootstrap.less file is an entry point, but cannot work in it's own.

I make use of wiredep project to scan the main property of my bower components for files that I need to link to or move around in order for my build to work. Right now everything else in this package works fine apart from less dependencies.

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 3, 2014

@juriejan main is for entry points only. Putting all the Less files in main would deviate too far from the bower spec and from actual practice observed in other projects. Proper tooling should be able to resolve bootstrap.less's imports.

@twbs twbs locked and limited conversation to collaborators Dec 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants