Remove unused Tooltip#validate method #14610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering that this is completely unused and undocumented, +1000 for nuking it from orbit. |
|
hm… why was this added in the first place, dont recall |
|
I guess it was copied over from tipsy: https://github.com/jaz303/tipsy/blob/3545aa6ae2cfdf10f3636d2754b792524ee2bc7a/src/javascripts/jquery.tipsy.js#L119-L125. Hasn't been touched since 11721f3#diff-eb8af357ea1148bb9810f632978c69ffR142. |
|
It seems to have the same purpose as our |
hnrch02
added a commit
that referenced
this pull request
Sep 16, 2014
Remove unused Tooltip#validate method
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is this i don't even