Add aria-pressed to single toggle buttons #14819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also includes tiny fix/clarification to two existing unit tests for the .active class, adding data-toggle=“button” explicitly to the tested buttons
|
just pinging @cvrebert as he's been super-active on this kind of accessibility-related stuff. i did a search through open issues, but didn't find - at first glance - any other PRs that deal with this tiny aspect. |
|
Seems reasonable to me. |
|
@cvrebert cool, i was more concerned whether or not some other effort was already under way to tackle this exact same problem :) |
|
Nope, not for this very specific case 😄 |
Closed
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons