Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .navbar-text margins #15239

Closed
wants to merge 1 commit into from
Closed

Fix .navbar-text margins #15239

wants to merge 1 commit into from

Conversation

bassjobsen
Copy link
Contributor

For .navbar-text the margins (left / right) should not wrapped into the media query to make sure that the .navbar-text don't differ from the nav links on the small grid.

For .navbar-text the margins (left / right) should not wrapped into the media query to make sure that the  .navbar-text don't differ from the nav links on the small grid.
@juthilo juthilo added the css label Nov 26, 2014
@juthilo juthilo added this to the v3.3.2 milestone Nov 26, 2014
@cvrebert
Copy link
Collaborator

Protip: In the future, use a better commit summary than the GitHub default of "Updated file-x.y"

@cvrebert cvrebert changed the title Update navbar.less Fix .navbar-text margins Nov 27, 2014
@mdo
Copy link
Member

mdo commented Nov 29, 2014

Have an example where this produces an undesirable presentation?

@bassjobsen
Copy link
Contributor Author

@mdo
Copy link
Member

mdo commented Nov 30, 2014

Works fine as-is, providing you're not placing those .navbar-texts within an <li> or something else.

@mdo mdo closed this Nov 30, 2014
@mdo mdo removed this from the v3.3.2 milestone Nov 30, 2014
@bassjobsen
Copy link
Contributor Author

@mdo, yes you're right that make sense. Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants