Prevent collapsed navbar in Non-responsive Example #15291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @mdo |
|
Might wanna actually delete that part of the code instead of just commenting it out. |
|
^^agreed |
The collapse button in navbar was removed because this example is non-responsive.
|
I commented it just to show the user how this example differs from the docs. Anyways, deleted. |
|
@cvrebert Done. |
|
@spectrumpixel: you should squash your patches into one. |
|
LGTM. |
|
Looks good to me. |
|
Sorry it took so long to circle back around on this one. Thanks for the fix! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page really wasn't fully non-responsive, so it was a bad example.
The navbar was partially collapsing.