Modal window, scrollbar shift regression

[thcipriani]

Current getbootstrap.com:

This was a problem that was originally solved by 0907244

A regression was caused by the removal of the line:

if (document.body.clientWidth >= window.innerWidth) return 0;

from the measureScrollbar function in commit da74fba

This seems like a mistake. Further, checking if document.body.scrollHeight > document.documentElement.clientHeight (the current scrollbar detection solution) is insufficient to check for the presence of scrollbars on IE10/IE11. IE10/IE11 don't have a scrollbar width since the scrollbar is hidden a majority of the time because of the CSS @-ms-viewport { width: device-width; }

I believe the situation is similar for Chrome on OSX, but I haven't tested that.

Either way, the solution in this commit shouldn't interfere with the goals of da74fba as far as I can tell AND fixes an important regression.

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 914e68f
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/43875883

(Please note that this is a fully automated comment.)

[cvrebert]

Hmm, still having Sauce connection issues. Will retry again later.
All the Sauce tests that did run were successful though, so that's encouraging.

[thcipriani]

@hnrch02—do you have any time to give this a quick review?

Just to make sure that I'm not missing anything critical about da74fba. There are definitely other ways to get at this issue if need be.

Thanks!

[hnrch02]

I'm unable to reproduce the problem in the first place. Which browser and OS did you use to take that GIF?

[thcipriani]

@hnrch02—the gif was produced with windows7 IE11.

I was able to confirm that this doesn't happen in chrome on OSX, as I had erroneously stated earlier—this is an issue with IE10/IE11 only, I believe.

[martin-g]

I'm experiencing the same problem in my application with Chrome 39 on Ubuntu 14.04.
With Bootstrap 3.3.0 there is no such problem. The problem appeared after updating to 3.3.1.
Looks like a duplicate to: #15229 .

[Khrysller]

Happens on W7 with IE9

[liu-xinhui]

I'm experiencing the same problem in ie10/ie11 with v3.3.2, v3.3.0 is well

[thcipriani]

Closing in favor of #15378