-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: test against node.js 0.12 #15778
Conversation
Why not just only test 0.12 and keep things simple? |
I don't mind either way. But if we don't test 0.10 we might hit the case where stuff break and we wouldn't know. Maybe we should keep both for a while and then only use 0.12? |
I'm wary of the increased chance of transient failures due to the extra builds that would imply. |
Why do you think we'd get build failures? I mean, only sauselabs is known to break, the other checks seem to work fine. Anyway, it's your call. Personally, I use 0.12 myself, but it would be nice to have a way of knowing if things work with 0.10 too in the future. Ideally, we should only have one version to support but it's too early to ditch 0.10... |
@XhmikosR I've had a number of builds where npm fails to install things correctly on TravisCI causing the tests to fail since they can't find the required modules. |
Works fine in our case. |
I would not call that "fine". False negatives from Travis PR builds are annoying. |
I honestly don't see any issue here. The issues arise with the custom npm cache stuff and sauselabs being what it is. |
FWIW I'm in favor of whatever is simplest and fastest for our tests. |
Well, the fastest would be to only have one node.js version. If everyone agrees we can drop 0.10 and move to 0.12, then. Personally, I have switched all my dev VMs to 0.12 and I don't plan going back since things seem to work rather well. |
Let's just switch to 0.12 then. Although I'd like to wait for uber-archive/npm-shrinkwrap#64 to be resolved first. |
OK, I made the change, feel free to merge or ping me if you need something. |
Cool, the npm-shrinkwrap PR was resolved impressively fast. Regenerated the shrinkwrap. This can be merged as soon as Travis finishes. |
@cvrebert: has Travis changed something? We seem to get 2 builds per PR. |
I think now it's just more apparent since GitHub changed how it displays build statuses. |
Travis: test against node.js 0.12.
/CC @cvrebert @mdo