Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: test against node.js 0.12 #15778

Merged
merged 1 commit into from
Feb 17, 2015
Merged

Travis: test against node.js 0.12 #15778

merged 1 commit into from
Feb 17, 2015

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR added the meta label Feb 10, 2015
@XhmikosR XhmikosR added this to the v3.3.4 milestone Feb 10, 2015
@cvrebert
Copy link
Collaborator

Why not just only test 0.12 and keep things simple?

@XhmikosR
Copy link
Member Author

I don't mind either way. But if we don't test 0.10 we might hit the case where stuff break and we wouldn't know.

Maybe we should keep both for a while and then only use 0.12?

@cvrebert
Copy link
Collaborator

I'm wary of the increased chance of transient failures due to the extra builds that would imply.

@cvrebert cvrebert added the build label Feb 10, 2015
@XhmikosR
Copy link
Member Author

Why do you think we'd get build failures? I mean, only sauselabs is known to break, the other checks seem to work fine.

Anyway, it's your call. Personally, I use 0.12 myself, but it would be nice to have a way of knowing if things work with 0.10 too in the future. Ideally, we should only have one version to support but it's too early to ditch 0.10...

@kkirsche
Copy link
Contributor

@XhmikosR I've had a number of builds where npm fails to install things correctly on TravisCI causing the tests to fail since they can't find the required modules.

@XhmikosR
Copy link
Member Author

Works fine in our case.

@cvrebert
Copy link
Collaborator

I would not call that "fine". False negatives from Travis PR builds are annoying.

@kkirsche
Copy link
Contributor

@XhmikosR I'm referring to builds from Bootstrap's tests.

Two quick examples of pull requests that Travis messed up on: #15744 #15725

@XhmikosR
Copy link
Member Author

I honestly don't see any issue here. The issues arise with the custom npm cache stuff and sauselabs being what it is.

@mdo
Copy link
Member

mdo commented Feb 11, 2015

FWIW I'm in favor of whatever is simplest and fastest for our tests.

@XhmikosR
Copy link
Member Author

Well, the fastest would be to only have one node.js version.

If everyone agrees we can drop 0.10 and move to 0.12, then.

Personally, I have switched all my dev VMs to 0.12 and I don't plan going back since things seem to work rather well.

@twbs twbs locked and limited conversation to collaborators Feb 14, 2015
@cvrebert
Copy link
Collaborator

Let's just switch to 0.12 then. Although I'd like to wait for uber-archive/npm-shrinkwrap#64 to be resolved first.

@XhmikosR
Copy link
Member Author

OK, I made the change, feel free to merge or ping me if you need something.

@cvrebert
Copy link
Collaborator

Cool, the npm-shrinkwrap PR was resolved impressively fast. Regenerated the shrinkwrap. This can be merged as soon as Travis finishes.

@XhmikosR
Copy link
Member Author

@cvrebert: has Travis changed something? We seem to get 2 builds per PR.

@cvrebert
Copy link
Collaborator

I think now it's just more apparent since GitHub changed how it displays build statuses.

cvrebert added a commit that referenced this pull request Feb 17, 2015
Travis: test against node.js 0.12.
@cvrebert cvrebert merged commit 75b3115 into master Feb 17, 2015
@cvrebert cvrebert deleted the node-012 branch February 17, 2015 05:29
@cvrebert cvrebert changed the title Travis: test against node.js 0.12 too. Travis: test against node.js 0.12 Feb 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants