Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the files to include in the npm package. #15809

Merged
merged 1 commit into from
Feb 16, 2015
Merged

Conversation

XhmikosR
Copy link
Member

Fixes #15397

/CC @cvrebert:

xmr@xmr-PC /c/Users/xmr/AppData/Roaming/npm/node_modules/bootstrap
$ ls -aR
.:
.  ..  LICENSE  README.md  fonts  js  less  package.json

./fonts:
.                                 glyphicons-halflings-regular.ttf
..                                glyphicons-halflings-regular.woff
glyphicons-halflings-regular.eot  glyphicons-halflings-regular.woff2
glyphicons-halflings-regular.svg

./js:
.   affix.js  button.js    collapse.js  modal.js    scrollspy.js  tooltip.js
..  alert.js  carousel.js  dropdown.js  popover.js  tab.js        transition.js

./less:
.                          grid.less          popovers.less
..                         input-groups.less  print.less
alerts.less                jumbotron.less     progress-bars.less
badges.less                labels.less        responsive-embed.less
bootstrap.less             list-group.less    responsive-utilities.less
breadcrumbs.less           media.less         scaffolding.less
button-groups.less         mixins             tables.less
buttons.less               mixins.less        theme.less
carousel.less              modals.less        thumbnails.less
close.less                 navbar.less        tooltip.less
code.less                  navs.less          type.less
component-animations.less  normalize.less     utilities.less
dropdowns.less             pager.less         variables.less
forms.less                 pagination.less    wells.less
glyphicons.less            panels.less

./less/mixins:
.                        grid.less                reset-filter.less
..                       hide-text.less           resize.less
alerts.less              image.less               responsive-visibility.less
background-variant.less  labels.less              size.less
border-radius.less       list-group.less          tab-focus.less
buttons.less             nav-divider.less         table-row.less
center-block.less        nav-vertical-align.less  text-emphasis.less
clearfix.less            opacity.less             text-overflow.less
forms.less               pagination.less          vendor-prefixes.less
gradients.less           panels.less
grid-framework.less      progress-bar.less

xmr@xmr-PC /c/Users/xmr/AppData/Roaming/npm/node_modules/bootstrap
$

Do we want the users to be able to run Grunt tasks when installed via npm? If so, I will need to include grunt and Gruntfile.js too.

@XhmikosR XhmikosR added the meta label Feb 14, 2015
@XhmikosR XhmikosR added this to the v3.3.4 milestone Feb 14, 2015
@cvrebert
Copy link
Collaborator

Yeah, might as well include the Grunt stuff like we do for the Bower package, imho.
Should we include /dist/ for folks who are fine with the precompiled version?

@XhmikosR
Copy link
Member Author

Allright I'll add those too. About dist I guess people might indeed rely on
it.

I'll include all of the above and merge this then.
On Feb 15, 2015 12:16 AM, "Chris Rebert" notifications@github.com wrote:

Yeah, might as well include the Grunt stuff like we do for the Bower
package, imho.
Should we include /dist/ for folks who are fine with the precompiled
version?


Reply to this email directly or view it on GitHub
#15809 (comment).

XhmikosR added a commit that referenced this pull request Feb 16, 2015
Specify the files to include in the npm package.
@XhmikosR XhmikosR merged commit f60067f into master Feb 16, 2015
@XhmikosR XhmikosR deleted the packages.json-files branch February 16, 2015 08:58
@cvrebert cvrebert mentioned this pull request Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm package has some cruft in it
2 participants