[Ref #15881] Use Explicit JS Variable Declarations rather than Chained #15923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Ref twbs#15881] Use Explicit Values for javascript variables rather than chained ones. From twbs#15881 (comment)
kkirsche
changed the title
|
The things is, UglifyJS doesn't compress this to one assignment chain: this.type = null, this.options = null, this.enabled = null, this.timeout = null, this.hoverState = null, this.$element = nullwhereas Closure is smart enough to do this: this.$element = this.hoverState = this.timeout = this.enabled = this.options = this.type = nullSo we'd have a slight increase in file size but I guess it a) isn't much and b) wouldn't matter with gzip. |
|
Plus, with v4 uglify won't be used so this won't matter. I'm personally in favor of readability. |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 238be65 (Please note that this is a fully automated comment.) |
hnrch02
added a commit
that referenced
this pull request
Feb 26, 2015
[Ref #15881] Use Explicit JS Variable Declarations rather than Chained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Ref #15881] Use Explicit Values for javascript variables rather than chained ones.
From #15881 (comment)
This should help individuals who are not well versed with ASI (Automatic Semicolon Insertion)