Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #15944] Add Z-Index to avoid border overlapping #15945

Merged
merged 1 commit into from Apr 5, 2015

Conversation

kkirsche
Copy link
Contributor

[Fixes #15944] Add Z-Index to avoid border overlapping

[Fixes twbs#15944] Add Z-Index to avoid border overlapping
@nextgenthemes
Copy link
Contributor

Nice but I am wondering if a z-index 2 (or any value for that matter) will not open up more problems when using this elements inside other z-indexed elements like modals and where bootstrap uses height z-indexes of 1000+ or just some custom z-indexed elements users may use.

@cvrebert cvrebert added the css label Feb 27, 2015
@vsn4ik
Copy link
Contributor

vsn4ik commented Feb 28, 2015

👍 for merge.

@kkirsche
Copy link
Contributor Author

kkirsche commented Mar 2, 2015

@twbs after reviewing the z-index variables from Variables.less should this be z-index: 1042 to accomodate @nextgenthemes comment.

@kkirsche
Copy link
Contributor Author

kkirsche commented Mar 5, 2015

Wanted to follow up on this and see what everyone thought.

@mdo
Copy link
Member

mdo commented Mar 8, 2015

Let's put together some examples via jsbin to see this stuff in action (the bug, the fix, and trying out a modal if you're concerned about z-index clashing).

@kkirsche
Copy link
Contributor Author

@mdo It seems to be working correctly with modals:

http://jsbin.com/nirafuvosu/1/edit?html,css,output

@twbs-lmvtfy
Copy link

Hi @kkirsche!

You appear to have posted a live example (http://jsbin.com/nirafuvosu/1/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

  • line 42, column 91: Duplicate ID exampleInputAmount.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@nextgenthemes
Copy link
Contributor

I guess I need to learn how z-indexes work when it comes to nesting and relatives, sorry.

@kkirsche
Copy link
Contributor Author

Wanted to follow up on this and check if it was missing anything.

1 similar comment
@kkirsche
Copy link
Contributor Author

Wanted to follow up on this and check if it was missing anything.

@mdo
Copy link
Member

mdo commented Mar 27, 2015

Let's :shipit:.

@mdo mdo added this to the v3.3.5 milestone Mar 27, 2015
mdo added a commit that referenced this pull request Apr 5, 2015
[Fixes #15944] Add Z-Index to avoid border overlapping
@mdo mdo merged commit 83d10bb into twbs:master Apr 5, 2015
@cvrebert cvrebert mentioned this pull request Apr 5, 2015
@kkirsche kkirsche deleted the patch-9 branch June 16, 2015 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input-group btn border overlap when hovered
6 participants