add role="button" to a[data-toggle="collapse"] #15987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't matter either way, but I'm not sure the role attribute needs to be applied to the tests at all. |
|
Need to double-check with some colleagues (some of these ARIA things are a bit...contentious in some cases) to make sure it's right. Stay tuned... |
|
Sorry, late reply, but this LGTM (and I tend more towards having the tests reflect expected/proper markup as much as possible, so I'm cool with having the unit tests include the |
cvrebert
added a commit
that referenced
this pull request
Mar 24, 2015
add role="button" to a[data-toggle="collapse"]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15972.
/to @patrickhlauke for review