Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding an uninitialized tooltip/popover no longer initializes it #15988

Merged
merged 1 commit into from
Mar 4, 2015

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Mar 3, 2015

Fixes #15874.
CC: @XhmikosR @hnrch02 for review

@cvrebert cvrebert added the js label Mar 3, 2015
@cvrebert cvrebert added this to the v3.3.4 milestone Mar 3, 2015
@@ -453,7 +453,7 @@
var data = $this.data('bs.tooltip')
var options = typeof option == 'object' && option

if (!data && option == 'destroy') return
if (!data && (option == 'destroy' || option == 'hide')) return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could go with /destroy|hide/.test(option) here but doesn't really matter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@hnrch02
Copy link
Collaborator

hnrch02 commented Mar 4, 2015

LGTM.

@hnrch02
Copy link
Collaborator

hnrch02 commented Mar 4, 2015

:shipit:

@XhmikosR
Copy link
Member

XhmikosR commented Mar 4, 2015

👍

cvrebert added a commit that referenced this pull request Mar 4, 2015
Hiding an uninitialized tooltip/popover no longer initializes it
@cvrebert cvrebert merged commit 3c19090 into master Mar 4, 2015
@cvrebert cvrebert deleted the fix-15874 branch March 4, 2015 09:40
@cvrebert cvrebert mentioned this pull request Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling any optionless method on element with no data-* attributes creates empty tooltip/popover object
3 participants