[V4] Use API visibility for Carousel #17710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be more revelant to see how it's work in |
|
@Johann-S I agree, it's not feasible to automatically unit test this. I think a visual test that listens for the |
| <script type="text/javascript"> | ||
| <!-- JavaScript Test --> | ||
| $(function () { | ||
| // Test to show that the carrousel don't slide when the current tab isn't visible |
|
Should add a note to the test, e.g.: <p>Also, the carousel shouldn't slide when its window/tab is hidden. Check the console log.</p> |
|
Done. |
|
Merged as 817d997. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this feature is for the carousel plugin to stop cycling when the page isn't visible
I re used your code @cvrebert to made my PR
I had a test unit but I think it's a bit hard to test that, if someone have a better idea how I can test that please let me know.
Because my test case is easy to test on a browser but difficult on Travis
X-Ref : #17706