replace grunt-autoprefixer with gruntpostcss + autoprefixer

[bassjobsen]

No description provided.

[cvrebert]

Use 2 spaces for indents

[bassjobsen]

yes thanks, i see. Done.

[XhmikosR]

Any change in dist files?

[bassjobsen]

dist files are unchanged (as expected)

[XhmikosR]

Then it should be OK.

[cvrebert]

needs to be indented another level

[cvrebert]

Modulo the indentation, LGTM.
We'll need to reshrinkwrap after merging this.

[XhmikosR]

@bassjobsen: can you fetch and rebase and also take care of @cvrebert's comments?

[bassjobsen]

i will try it this weekend. I'm not sure if i do understand the rebase thing.

[bassjobsen]

Well i tried / try to do the rebase.
i'm not sure i did it right.
I also found some diffs in dist now:

    4893,4894c4893
    <        -o-transition:         transform .3s ease-out, -o-transform .3s ease-out;
    <           transition: -webkit-transform .3s ease-out;
    ---
    >        -o-transition:      -o-transform .3s ease-out;
    4896d4894
    <           transition:         transform .3s ease-out, -webkit-transform .3s ease-out, -o-transform .3s ease-out;
    5289,5290c5287
    <          -o-transition:         transform .6s ease-in-out, -o-transform .6s ease-in-out;
    <             transition: -webkit-transform .6s ease-in-out;
    ---
    >          -o-transition:      -o-transform .6s ease-in-out;
    5292d5288
    <             transition:         transform .6s ease-in-out, -webkit-transform .6s ease-in-out, -o-transform .6s ease-in-out;

[bassjobsen]

i do not understand why 31 files are change now? @XhmikosR should i better create a new PR now?

[wolfy1339]

You didn't do the rebase properly, which would account for the extra unwanted commits and file changes.
I would make a new one, it's easier and faster.

[kkirsche]

I'd agree that it's easier and faster to make a new one @bassjobsen. I'd recommend this guide on how to rebase https://help.github.com/articles/about-git-rebase/ if you aren't familiar with it / don't do it often

[XhmikosR]

git rebase -i upstream/v4-dev

[kkirsche]

@XhmikosR for the sake of being complete, git fetch upstream && git rebase -i upstream/v4-dev

EDIT: I had the wrong syntax for git fetch

[bassjobsen]

okay thanks, i will create a new PR soon

[XhmikosR]

That is not in order to create a new PR...

[bassjobsen]

@XhmikosR yes i understand, i will repeat my changes on the latest version and add it to a new PR

[XhmikosR]

Good catch, indeed it does.

[bassjobsen]

@wolfy1339 yes i see, but https://github.com/bassjobsen/bootstrap/commit/52b5bd5ce99e2c125b16939ea6e0101381756b55 repairs this?

[wolfy1339]

That commit won't cut it either. You would need to rewrite the git history of your branch to only have your changes.
When you do a rebase, you need to do a force push by using git push -f, so the git history is replaced and nothing unwanted happens.
Since you don't seem comfortable with rebase, I would recommend that you create a new pull request and not that it superseded this one.

[cvrebert]

Leave this open. I'm rebasing and merging this myself.

[cvrebert]

@XhmikosR This is why I always recommend qualifying requests for rebases with "if you are comfortable+familiar with rebasing..."

[cvrebert]

Rebased. Running Travis build: https://travis-ci.org/twbs/bootstrap/builds/90641415

[cvrebert]

Build failed. Retrying now that #17652 has been merged.
https://travis-ci.org/twbs/bootstrap/builds/90642551

[cvrebert]

There seems to be a problem installing phantomjs@1.9.18 under Node.js v4.2.2 & npm@2.14.7.

[cvrebert]

Forcing npm@3 fixes that problem, but now some unrelated random RVM problem has raised its head:
https://travis-ci.org/twbs/bootstrap/builds/90644598

[cvrebert]

Filed travis-ci/travis-ci#5092. Travis is missing curl for some reason, which causes the RVM problem.

[XhmikosR]

Why did you need to upgrade Ruby anyway? I use 2.2 in another project of mine without any issues.

[XhmikosR]

env:
  matrix:
    - RUBY_VERSION=2.2

before_install:
  - rvm install $RUBY_VERSION
  - rvm use $RUBY_VERSION --fuzzy
  - export GEMDIR=$(rvm gemdir)

@cvrebert: try this, it should work.

[XhmikosR]

Also, we shouldn't force npm@3 either. I mean, I'm using 2.x locally just fine. Did you try to clear Travis cache just in case?

[XhmikosR]

@cvrebert: this seems to pass 9b50133
https://travis-ci.org/twbs/bootstrap/builds/90675687

[cvrebert]

Didn't really need to upgrade Ruby. I was just grasping at straws when debugging the RVM issue.

this seems to pass 9b50133
https://travis-ci.org/twbs/bootstrap/builds/90675687

@XhmikosR Looks good, you should open a PR for that.

[cvrebert]

No, haven't tried clearing the Travis cache.

[XhmikosR]

Shouldn't I just merge that then?

[cvrebert]

Nicely done: 7b19dfc

[cvrebert]

For whatever reason, the RVM error is no longer occurring.

[cvrebert]

Purged the caches and building one more time to verify whether npm@3 is truly necessary:
https://travis-ci.org/twbs/bootstrap/builds/90687640

[cvrebert]

Build failed. @XhmikosR Yup, npm@3 is needed to install from an npm@3 shrinkwrap, which is reasonable. I'm guessing you don't see it locally since you're probably not installing via shrinkwrap.

[XhmikosR]

@cvrebert: we don't use a v3.x shrinkwrap, do we?

[cvrebert]

@XhmikosR npm v3 is the latest stable major version of npm and seems to the preinstalled version for Node.js v5. And it's compatible with Node.js v4. Since the shrinkwrap is only used internally, I don't see much reason to use an old version.
(My branch switches to npm v3 shrinkwrap since I have Node.js v5 on my local box.)

[cvrebert]

Rebased and merged as 50c43bc. Thanks @bassjobsen!

@XhmikosR Feel free to argue about 3236a4d tomorrow 😄

[XhmikosR]

The thing is, I don't want to use v5.0.0 yet... This broke my branch and I will need to use npm 3.x to rebase it.