Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-col mixin is missing a $gutter parameter? #19147

Closed
julien-gargot opened this issue Feb 10, 2016 · 1 comment
Closed

make-col mixin is missing a $gutter parameter? #19147

julien-gargot opened this issue Feb 10, 2016 · 1 comment
Labels
css v4
Milestone
v4.0.0-alpha.3

Comments

@julien-gargot
Copy link

#19099

17512, #17514: Overhauls the grid mixins to merge make-col and make-col-span into a single make-col mixin, thereby ensuring mixins and predefined classes utilize the same float/flex behaviors.

Problem is, now, you have to override row-padding for working with contextual gutter widths.
If you can use make-container($gutter) and make-row($gutter), it could makes sense to have a $gutter parameter in make-col($size, $columns) too. What do you think?
@cvrebert cvrebert changed the title Inconsistency in the use of row/colmuns mixins make-col mixin is missing a $gutter parameter? Feb 17, 2016
@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Feb 17, 2016
cvrebert added a commit that referenced this issue Feb 17, 2016
@cvrebert
Add $gutter parameter to make-col mixin; fixes #19147
43d0d45 
[skip sauce]
[skip validator]
@cvrebert cvrebert mentioned this issue Feb 17, 2016
Merged
@cvrebert
Copy link
Collaborator

Fixed by #19257. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
2 participants
@cvrebert @julien-gargot