Rename .text-xs-* to .text-*
#21217
Merged
Rename .text-xs-* to .text-*
#21217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 27, 2016
| .text-#{$breakpoint}-center { text-align: center !important; } | ||
| } @else { | ||
| .text-left { text-align: left !important; } | ||
| .text-right { text-align: right !important; } |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
houndci-bot
reviewed
Nov 27, 2016
| .text-#{$breakpoint}-right { text-align: right !important; } | ||
| .text-#{$breakpoint}-center { text-align: center !important; } | ||
| } @else { | ||
| .text-left { text-align: left !important; } |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
houndci-bot
reviewed
Nov 27, 2016
|
|
||
| @if $min { | ||
| .text-#{$breakpoint}-left { text-align: left !important; } | ||
| .text-#{$breakpoint}-right { text-align: right !important; } |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
houndci-bot
reviewed
Nov 27, 2016
| $min: breakpoint-min($breakpoint, $grid-breakpoints); | ||
|
|
||
| @if $min { | ||
| .text-#{$breakpoint}-left { text-align: left !important; } |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
Closed
asterion
pushed a commit
to asterion/rails_layout
that referenced
this pull request
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a trend that we're removing
xsfrom class names, so I thought that we should do this for the text utilities too. All I did was grep all the files for lines containingtext-xs-and replaced that with justtext-, and use the SCSS logic fromscss/utilities/_spacing.scss(at line 20) to get rid of the-xs.