Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant media queries #21220

Merged
merged 1 commit into from Nov 27, 2016
Merged

Remove redundant media queries #21220

merged 1 commit into from Nov 27, 2016

Conversation

Starsam80
Copy link
Contributor

These media queries for min-width were unnecessary and produced stuff like

@media (min-width: 576px) and (min-width: 576px) {
  /* Some CSS here */
}

Removing these queries fixes this.

P.S.: Lately, I've been noticing a lot of stuff weird/wrong with the code, so expect some PRs from me. I would like to do a giant PR with all of my fixes but that would be annoying to review, so I'm splitting it up into several different ones. With this method, it would also be easier to reject some changes by just closing the PR.

@mdo
Copy link
Member

mdo commented Nov 27, 2016

P.S.: Lately, I've been noticing a lot of stuff weird/wrong with the code, so expect some PRs from me. I would like to do a giant PR with all of my fixes but that would be annoying to review, so I'm splitting it up into several different ones. With this method, it would also be easier to reject some changes by just closing the PR.

Holy crap yes pls to all of that. 😻 Super appreciative of all these PRs from you lately <3.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 27, 2016
@mdo mdo merged commit 94be2d2 into twbs:v4-dev Nov 27, 2016
@Starsam80 Starsam80 deleted the remove-redundant-media branch November 27, 2016 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants