Reset button element border-radius in Reboot #24126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
approved these changes
Sep 26, 2017
XhmikosR
approved these changes
Sep 26, 2017
|
So this change doesn't have any side effects? I know we basically override the |
|
@XhmikosR no side effects, we bring the border radius back here: |
Closed
|
When using only the reboot stylesheet, the button style differs from the input style in Firefox. Here is a screenshot (made in Comparing CSS resets): Disabling the border-radius fixes this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24093.
This goes in Reboot vs the
.btnclass given it affects<button>elements everywhere (e.g., dropdown items). This shouldn't affect the display much given we neutralize a bunch of other styles on the<button>element already./cc @razh