Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add map-name param to _assert-starts-at-zero #24986

Merged
merged 4 commits into from Feb 7, 2019
Merged

Add map-name param to _assert-starts-at-zero #24986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4944dc
Add map-name param to _assert-starts-at-zero
zacharywelch Dec 11, 2017
ecd5112
Merge branch 'v4-dev' into zw/assert-starts-at-zero-map-name
XhmikosR Nov 13, 2018
39b745f
Set default value for backwards compatibility
MartijnCuppens Feb 7, 2019
7de36c9
Merge branch 'v4-dev' into zw/assert-starts-at-zero-map-name
MartijnCuppens Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions scss/_functions.scss
View file
Open in desktop
Expand Up @@ -21,12 +21,12 @@
}

// Starts at zero
// Another grid mixin that ensures the min-width of the lowest breakpoint starts at 0.
@mixin _assert-starts-at-zero($map) {
// Used to ensure the min-width of the lowest breakpoint starts at 0.
@mixin _assert-starts-at-zero($map, $map-name: "$grid-breakpoints") {
$values: map-values($map);
$first-value: nth($values, 1);
@if $first-value != 0 {
@warn "First breakpoint in `$grid-breakpoints` must start at 0, but starts at #{$first-value}.";
@warn "First breakpoint in #{$map-name} must start at 0, but starts at #{$first-value}.";
}
}

Expand Down
2 changes: 1 addition & 1 deletion scss/_variables.scss
View file
Open in desktop
Expand Up @@ -196,7 +196,7 @@ $grid-breakpoints: (
) !default;

@include _assert-ascending($grid-breakpoints, "$grid-breakpoints");
@include _assert-starts-at-zero($grid-breakpoints);
@include _assert-starts-at-zero($grid-breakpoints, "$grid-breakpoints");


// Grid containers
Expand Down