Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow background images for active buttons #25740

Merged
merged 3 commits into from Jul 21, 2018
Merged

Conversation

MartijnCuppens
Copy link
Member

Background images are removed from active buttons. This was initially done to remove the gradients in Bootstrap 3. In v4 this behaviour was moved to scss/mixins/_buttons.scss and only applied when gradients are enabled.

@if $enable-gradients {
background-image: none; // Remove the gradient for the pressed/active state
}

This code was never removed in scss/_buttons.scss:

background-image: none;

@mdo mdo added this to Inbox in v4.2 via automation Mar 2, 2018
@mdo mdo added this to Inbox in v4.1.3 via automation Jul 21, 2018
@mdo mdo removed this from Inbox in v4.2 Jul 21, 2018
@mdo mdo merged commit c74a327 into twbs:v4-dev Jul 21, 2018
v4.1.3 automation moved this from Inbox to Shipped Jul 21, 2018
@mdo mdo mentioned this pull request Jul 21, 2018
@MartijnCuppens MartijnCuppens deleted the patch-2 branch July 21, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.1.3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants