Add back IE11 support #28516
Merged
Add back IE11 support #28516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
force-pushed
the
jo-add-back-ie11-support
branch
from
d5c5e79
to
cbfa5e9
Compare
XhmikosR
force-pushed
the
jo-add-back-ie11-support
branch
from
b46599d
to
f27d496
Compare
XhmikosR
force-pushed
the
jo-add-back-ie11-support
branch
3 times, most recently
from
07f4e5b
to
1f7b40a
Compare
XhmikosR
changed the title
Johann-S
force-pushed
the
jo-add-back-ie11-support
branch
from
09638a0
to
7e756c2
Compare
XhmikosR
force-pushed
the
jo-add-back-ie11-support
branch
from
7e756c2
to
b29dc59
Compare
|
LGTM. Let's wait for another approval for the CSS reverts from @twbs/css-review |
XhmikosR
force-pushed
the
jo-add-back-ie11-support
branch
2 times, most recently
from
16c193d
to
b86301b
Compare
Johann-S
force-pushed
the
jo-add-back-ie11-support
branch
from
b86301b
to
3048a84
Compare
MartijnCuppens
approved these changes
Mar 17, 2019
XhmikosR
force-pushed
the
jo-add-back-ie11-support
branch
from
ed28206
to
dd2161e
Compare
This reverts commit 089e333.
XhmikosR
force-pushed
the
jo-add-back-ie11-support
branch
from
dd2161e
to
a1f46e3
Compare
coliff
reviewed
Mar 18, 2019
| {{< callout danger >}} | ||
| #### Cross-browser compatibility | ||
|
|
||
| While Bootstrap will apply these styles in all browsers, Internet Explorer 11 and below don't fully support the `disabled` attribute on a `<fieldset>`. Use custom JavaScript to disable the fieldset in these browsers. |
There was a problem hiding this comment.
Suggest changing the line to:
Internet Explorer 11 doesn't fully support the
disabled
(no need to mention 'and below')
There was a problem hiding this comment.
This was merged before your comments so it's moot. You can make PRs, as usual.
coliff
reviewed
Mar 18, 2019
| {{< callout warning >}} | ||
| ##### Flexbug #12: Inline elements aren't treated as flex items | ||
|
|
||
| Internet Explorer 10-11 do not render inline elements like links or images (or `::before` and `::after` pseudo-elements) as flex items. The only workaround is to set a non-inline `display` value (e.g., `block`, `inline-block`, or `flex`). We suggest using `.d-flex`, one of our [display utilities]({{< docsref "/utilities/display" >}}), as an easy fix. |
There was a problem hiding this comment.
Suggest changing this sentence to start with:
Internet Explorer 11 does not render inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests will fail when we add IE 11 in BrowserStack because we have to add polyfills in our unit tests