Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CircleCI #28582

Closed
wants to merge 7 commits into from
Closed

Switch to CircleCI #28582

wants to merge 7 commits into from

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 31, 2019

Note that the Pull Request status isn't updated. I will enable this when we merge the PR and have the other branches work with CircleCI.

TODO:

  • Fix BrowserStack tests for our PRs
  • Enable CircleCI in branch protection rules
  • Remove Travis from the repo and branch protection rules
  • Enable GitHub PR integration in CircleCI
  • Add Bundlesize in CircleCI
  • Add Coveralls in CircleCI

Maybe later:

  • Split workflow to, install, lint, build css and js, build docs etc

https://circleci.com/gh/twbs/bootstrap

@XhmikosR XhmikosR added this to Inbox in v5 via automation Mar 31, 2019
@XhmikosR XhmikosR added this to Inbox in v4.4.0 via automation Mar 31, 2019
@XhmikosR XhmikosR force-pushed the master-xmr-circle-ci branch 7 times, most recently from 04a218a to d534b1c Compare April 2, 2019 17:08
@XhmikosR XhmikosR force-pushed the master-xmr-circle-ci branch 3 times, most recently from d622223 to 35b0a7d Compare April 15, 2019 13:00
@XhmikosR XhmikosR force-pushed the master-xmr-circle-ci branch 3 times, most recently from 80f86eb to 52ba00b Compare April 30, 2019 11:31
@XhmikosR XhmikosR force-pushed the master-xmr-circle-ci branch 2 times, most recently from e7733d8 to b5d98aa Compare May 3, 2019 12:40
@XhmikosR XhmikosR marked this pull request as ready for review May 3, 2019 12:40
README.md Outdated Show resolved Hide resolved
@mdo
Copy link
Member

mdo commented May 3, 2019

Tell me when we're ready to go on me doing those todos and I'll dig in.

@XhmikosR XhmikosR force-pushed the master-xmr-circle-ci branch 3 times, most recently from 8214bd5 to 500026c Compare May 8, 2019 10:11
@XhmikosR XhmikosR force-pushed the master-xmr-circle-ci branch 3 times, most recently from f1d6d7c to 0dc0c00 Compare May 16, 2019 13:13
@MartijnCuppens
Copy link
Member

What's the status here? It looks like the only things that need to be done are repo configuration?

@XhmikosR
Copy link
Member Author

All minus bundlesize which I need the token IIRC.

@XhmikosR
Copy link
Member Author

I'm gonna put this on hold for now.

Because there doesn't seem to be a way for the tokens like bundlesize and coveralls to be encrypted, so better be safe. Or we'd miss these checks for forked PRs.

@XhmikosR XhmikosR closed this Jun 27, 2019
@XhmikosR XhmikosR removed this from Inbox in v5 Jun 27, 2019
@XhmikosR XhmikosR removed this from Inbox in v4.4.0 Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants