New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split grid & containers #29146
Split grid & containers #29146
Conversation
Why wouldn't we continue to wrap all this in a the |
The containers and grid system are two different things IMO, they can be used independent. |
Why not organize the mixin files? |
Containers are required for grid system though, too, because of the horizontal padding. |
I agree with @MartijnCuppens. What is required is not a |
Valid point. However, the Or maybe we should introduce a new |
0e752e9
to
1fab174
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revisiting this, I'm fine to do the split here and give folks more granular control. @MartijnCuppens let me know if you want to handle in the first alpha or subsequent release.
74fa929
to
e49ef44
Compare
e49ef44
to
8ac8239
Compare
The grid and containers are 2 different components, let's split them into different scss files.