Tweak colors to be WCAG 2AA valid #29198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
requested review from
patrickhlauke
and removed request for
patrickhlauke
XhmikosR
force-pushed
the
master-xmr-colors
branch
from
c57f058
to
c95cb49
Compare
XhmikosR
changed the title
XhmikosR
force-pushed
the
master-xmr-colors
branch
2 times, most recently
from
6abf8ec
to
c843cf6
Compare
|
I split the doc-related fixes to #29208. I'll rebase this after the merge and see where we are at. |
XhmikosR
force-pushed
the
master-xmr-colors
branch
2 times, most recently
from
f5a2042
to
e8c99ef
Compare
XhmikosR
force-pushed
the
master-xmr-colors
branch
8 times, most recently
from
d129128
to
cab6ddb
Compare
XhmikosR
force-pushed
the
master-xmr-colors
branch
from
cab6ddb
to
ddee16b
Compare
XhmikosR
force-pushed
the
master-xmr-colors
branch
from
ddee16b
to
a6fd76d
Compare
|
@patrickhlauke: any suggestions? |
|
Maybe we should move forward with the blue and pink changes only since those are the least intrusive ones? |
Yup |
XhmikosR
force-pushed
the
master-xmr-colors
branch
from
c08a62e
to
8bbe510
Compare
|
Alright, I cleaned up the patch. I don't think we should backport this, though, because it can be a breaking change for some people. @mdo please confirm if you are OK with these 2 color changes. The difference isn't that big. |
mdo
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to push here any further color tweaks. I check this on our docs page, but the highlighting colors mostly don't pass WCAG 2.0 AA so this makes it harder.
Also, not sure if this should be backported or not.
Preview: https://deploy-preview-29198--twbs-bootstrap.netlify.com/
TODO:
#0d6efd#d63384