Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transition and add box-shadow for navbar-toggler #30038

Merged
merged 7 commits into from
Jan 28, 2020

Conversation

Cinnead
Copy link
Contributor

@Cinnead Cinnead commented Jan 17, 2020

Add box-shadow on focus for the navbar-toggler and add transition for animating the box-shadow

closes #30016

Demo: https://deploy-preview-30038--twbs-bootstrap.netlify.com/docs/4.3/components/navbar/#color-schemes

@Cinnead Cinnead requested a review from a team as a code owner January 17, 2020 09:50
@XhmikosR XhmikosR requested review from mdo and ysds January 23, 2020 13:49
@XhmikosR XhmikosR added this to Inbox in v5 via automation Jan 23, 2020
@XhmikosR XhmikosR added the v5 label Jan 23, 2020
@MartijnCuppens
Copy link
Member

Ping @twbs/css-review for second approval

@MartijnCuppens MartijnCuppens merged commit 770d95e into twbs:master Jan 28, 2020
v5 automation moved this from Inbox to Shipped Jan 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Inconsistent navbar toggler focus state
3 participants