Remove confusing "Equal-width multi-line" section from Grid docs. #30189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the grid docs from top to bottom, this section made no sense to me. I didn't understand why you wouldn't just use multiple rows, and I had no idea what w-100 meant, or how you'd "mix" it with "responsive display utilities". Then I continued reading and got to https://getbootstrap.com/docs/4.4/layout/grid/#column-breaks which explains the same concept but with a much better explanation and examples (including the responsive display utilities). It looks like the "Equal-width multi-line" section was added in 9010978 to resolve to twbs#21967 as a way to document the existence of a Safari bug. But that bug has long since been fixed (Safari 10.1 came out in May 2017) and so I think it's reasonable to just drop this section and rely on the better docs further down in the guide.
|
This can probably go away with |
Yup, this section is way clearer indeed.
Indeed, therefore it would also be better to remove this confusing section. |
MartijnCuppens
approved these changes
Feb 16, 2020
|
Thanks for taking your time to make a PR for this, @mikelehen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the grid docs from top to bottom, this section made no sense to me. I didn't understand why you wouldn't just use multiple rows, and I had no idea what w-100 meant, or how you'd "mix" it with "responsive display utilities".
Then I continued reading and got to https://getbootstrap.com/docs/4.4/layout/grid/#column-breaks which explains the same concept but with a much better explanation and examples (including the responsive display utilities).
It looks like the "Equal-width multi-line" section was added in 9010978 to resolve to #21967 as a way to document the existence of a Safari bug. But that bug has long since been fixed (Safari 10.1 came out in May 2017) and so I think it's reasonable to just drop this section and rely on the better docs further down in the guide.