Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form file height #30699

Merged
merged 3 commits into from
May 5, 2020
Merged

Fix form file height #30699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcf5466
feat(form-file): set height on input+label using custom property
ffoodd Apr 30, 2020
f4ff6a9
Merge branch 'master' into master-fod-form-file-validation-feedback
MartijnCuppens May 4, 2020
b4c7512
Merge branch 'master' into master-fod-form-file-validation-feedback
MartijnCuppens May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions scss/forms/_form-file.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
.form-file {
--bs-form-file-height: #{$form-file-height};
position: relative;
height: $form-file-height;
}

.form-file-input {
position: relative;
z-index: 2;
width: 100%;
height: 100%;
height: var(--bs-form-file-height);
margin: 0;
opacity: 0;

Expand All @@ -32,7 +32,7 @@
left: 0;
z-index: 1;
display: flex;
height: 100%;
height: var(--bs-form-file-height);
border-color: $form-file-border-color;
@include border-radius($form-file-border-radius);
@include box-shadow($form-file-box-shadow);
Expand Down Expand Up @@ -71,7 +71,7 @@
}

.form-file-sm {
height: $form-file-height-sm;
--bs-form-file-height: #{$form-file-height-sm};
@include font-size($form-file-font-size-sm);

.form-file-text,
Expand All @@ -81,7 +81,7 @@
}

.form-file-lg {
height: $form-file-height-lg;
--bs-form-file-height: #{$form-file-height-lg};
@include font-size($form-file-font-size-lg);

.form-file-text,
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/4.3/forms/validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ Validation styles are available for the following form controls and components:
<div class="invalid-feedback">Example invalid select feedback</div>
</div>

<div class="form-file">
<div class="form-file mb-3">
<input type="file" class="form-file-input" id="validationFormFile" required>
<label class="form-file-label" for="validationFormFile">
<span class="form-file-text">Choose file...</span>
Expand Down