Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _custom-forms.scss #30762

Closed
wants to merge 1 commit into from
Closed

Update _custom-forms.scss #30762

wants to merge 1 commit into from

Conversation

arthurshlain
Copy link

Typo in box-shadow attribute, global variable used instead of local.

Found this because i cannot set checkbox shadow to none on focus state.
Checkbox shadow dissapear only when i turn off all shadow, but it's not true way to solve it.

Typo in box-shadow attribute, global variable used instead of local.
@arthurshlain arthurshlain requested a review from a team as a code owner May 7, 2020 14:44
@XhmikosR
Copy link
Member

XhmikosR commented Jun 4, 2020

@twbs/css-review is this still valid?

@ffoodd
Copy link
Member

ffoodd commented Jun 4, 2020

I guess so, and it makes sense since $custom-control-indicator-focus-box-shadow is set to match $input-focus-box-shadow ATM.

However this should not be used to remove box-shadow: as mentionned in the comment above, // the mixin is not used here to make sure there is feedback. If $custom-control-indicator-focus-box-shadow is null or none, there would be no focus indicator anymore…

To clarify, this fix is good, but shouldn't be used as requested. Not sure about what to do with this though. @MartijnCuppens @mdo any idea?

@XhmikosR
Copy link
Member

XhmikosR commented Jun 4, 2020

Isn't this present in master too? If so please add the needed labels.

@ffoodd
Copy link
Member

ffoodd commented Jun 4, 2020

master only sets a single box-shadow, with a specific variable, so it can be nullified at any time.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is valid still—slating for v4.5.3!

@mdo mdo mentioned this pull request Sep 17, 2020
@mdo
Copy link
Member

mdo commented Sep 17, 2020

Looks like the remote is no longer there—tests look a little wonky here. Replacing with #31693.

@mdo mdo closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants