v5: Redo blockquote attributions #30814
Conversation
This comment has been minimized.
This comment has been minimized.
|
FWIW, as commented in #30085, the only missing occurrence in your PR is in the Masonry Example: https://deploy-preview-30814--twbs-bootstrap.netlify.app/docs/5.0/examples/masonry/ |
|
And now I see we had it in the TODO already 😛 |
|
@ffoodd if you have some time, can you update the rest of the instances so that we land this please? |
|
Done. @mdo The Masonry examples changes a bit with this refactor: since paragraphs become blockquote's We may reintroduce the previous result by applying |
- Renames -small-* variables to -footer-* - Updates blockquote demos with attribution to place it outside the blockquote with a figure wrapper
|
I think the masonry page looks fine as-is—not a huge change. Thanks for making the last changes, this looks great! |
|
Yep, that works. 👍 |
* v5: Redo blockquote attributions - Renames -small-* variables to -footer-* - Updates blockquote demos with attribution to place it outside the blockquote with a figure wrapper * Updated class name * docs(examples): refactor blockquotes in masonry example Co-authored-by: Gaël Poupard <gael.poupard@orange.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This is an alternate to #30085.
$blockquote-small-*variables to$blockquote-footer-*TODO:
Preview: https://deploy-preview-30814--twbs-bootstrap.netlify.app/docs/5.0/content/typography/#naming-a-source