Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to badges #31132

Merged
merged 9 commits into from
Aug 2, 2020
Merged

Add padding to badges #31132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
659f81b
Add padding to badges
patrickhlauke Jun 21, 2020
1c61575
Merge branch 'main' into v5-badge-padding
patrickhlauke Jun 21, 2020
965a2af
Merge branch 'main' into v5-badge-padding
XhmikosR Jun 24, 2020
795a1a7
Merge branch 'main' into v5-badge-padding
patrickhlauke Jul 4, 2020
171f49c
Merge branch 'main' into v5-badge-padding
patrickhlauke Jul 20, 2020
51d68f2
Tweak vertical padding
patrickhlauke Jul 20, 2020
235474c
Merge branch 'main' into v5-badge-padding
patrickhlauke Jul 31, 2020
df57fe6
Note padding change in migration document
patrickhlauke Aug 1, 2020
a91c6b0
Merge branch 'main' into v5-badge-padding
patrickhlauke Aug 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,8 +1067,8 @@ $toast-header-border-color: rgba(0, 0, 0, .05) !default;
$badge-font-size: .75em !default;
$badge-font-weight: $font-weight-bold !default;
$badge-color: $white !default;
$badge-padding-y: .25em !default;
$badge-padding-x: .5em !default;
$badge-padding-y: .35em !default;
$badge-padding-x: .65em !default;
$badge-border-radius: $border-radius !default;


Expand Down
4 changes: 4 additions & 0 deletions site/content/docs/5.0/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ toc: true

### Components

### Badges

- Increased default padding for badges from `.25em`/`.5em` to `.35em`/`.65em`.

#### Buttons

- Disabled states of buttons are easier to customize thanks to additional arguments in the `button-variant()` mixin. [See #30639.](https://github.com/twbs/bootstrap/pull/30639)
Expand Down