Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Chinese Simplified translation #31540

Merged
merged 3 commits into from Sep 20, 2020
Merged

Add new Chinese Simplified translation #31540

merged 3 commits into from Sep 20, 2020

Conversation

MrWillCom
Copy link

This is an open source Chinese Simplified translation which is more pure than another one.

@MrWillCom
Copy link
Author

Also, can we start translating v5's docs? If we can, which branch should we start from?

@mdo mdo added this to Inbox in v4.5.3 via automation Sep 14, 2020
@mdo
Copy link
Member

mdo commented Sep 17, 2020

Also, can we start translating v5's docs? If we can, which branch should we start from?

I'd wait on that for at least the beta release.

@XhmikosR
Copy link
Member

@MrWillCom please rebase your branch and make sure the check to allow edits from maintainers is ticked in the future.

@MrWillCom
Copy link
Author

@MrWillCom please rebase your branch and make sure the check to allow edits from maintainers is ticked in the future.

I didn't find the checkbox of "Allow edits from maintainers" even I've read Allowing changes to a pull request branch created from a fork - GitHub Docs. So how to allow it?

@XhmikosR
Copy link
Member

Please just rebase your fork yourself so that we can proceed with this. If you need help consult GitHub's article.

@MrWillCom
Copy link
Author

Please just rebase your fork yourself so that we can proceed with this. If you need help consult GitHub's article.

I followed the article, commit 0f8d69a .

@XhmikosR XhmikosR changed the title Add new Chinese Simplified translation #30879 Add new Chinese Simplified translation Sep 20, 2020
@XhmikosR XhmikosR merged commit ab0aec3 into twbs:v4-dev Sep 20, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.3 Sep 20, 2020
@MrWillCom
Copy link
Author

MrWillCom commented Sep 21, 2020

@XhmikosR It looks like that getbootstrap.com is not updated currently, maybe it needs a rebuild?

@XhmikosR
Copy link
Member

The live website will be updated when we make a new release.

@MrWillCom
Copy link
Author

The live website will be updated when we make a new release.

Okay, thanks a lot. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.3
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants