Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setData from construtors #32264

Merged
merged 1 commit into from Nov 29, 2020
Merged

Remove setData from construtors #32264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion js/src/carousel.js
View file
Open in desktop
Expand Up @@ -123,7 +123,6 @@ class Carousel extends BaseComponent {
this._pointerEvent = Boolean(window.PointerEvent)

this._addEventListeners()
Data.setData(element, DATA_KEY, this)
}

// Getters
Expand Down
2 changes: 0 additions & 2 deletions js/src/collapse.js
View file
Open in desktop
Expand Up @@ -101,8 +101,6 @@ class Collapse extends BaseComponent {
if (this._config.toggle) {
this.toggle()
}

Data.setData(element, DATA_KEY, this)
}

// Getters
Expand Down
1 change: 0 additions & 1 deletion js/src/dropdown.js
View file
Open in desktop
Expand Up @@ -106,7 +106,6 @@ class Dropdown extends BaseComponent {
this._inNavbar = this._detectNavbar()

this._addEventListeners()
Data.setData(element, DATA_KEY, this)
}

// Getters
Expand Down
1 change: 0 additions & 1 deletion js/src/modal.js
View file
Open in desktop
Expand Up @@ -93,7 +93,6 @@ class Modal extends BaseComponent {
this._ignoreBackdropClick = false
this._isTransitioning = false
this._scrollbarWidth = 0
Data.setData(element, DATA_KEY, this)
}

// Getters
Expand Down
2 changes: 0 additions & 2 deletions js/src/scrollspy.js
View file
Open in desktop
Expand Up @@ -81,8 +81,6 @@ class ScrollSpy extends BaseComponent {

this.refresh()
this._process()

Data.setData(element, DATA_KEY, this)
}

// Getters
Expand Down
1 change: 0 additions & 1 deletion js/src/toast.js
View file
Open in desktop
Expand Up @@ -67,7 +67,6 @@ class Toast extends BaseComponent {
this._config = this._getConfig(config)
this._timeout = null
this._setListeners()
Data.setData(element, DATA_KEY, this)
}

// Getters
Expand Down
1 change: 0 additions & 1 deletion js/src/tooltip.js
View file
Open in desktop
Expand Up @@ -144,7 +144,6 @@ class Tooltip extends BaseComponent {
this.tip = null

this._setListeners()
Data.setData(element, this.constructor.DATA_KEY, this)
}

// Getters
Expand Down