Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variables for modifying button state colours. #32317

Merged
merged 3 commits into from Dec 17, 2020
Merged

Add variables for modifying button state colours. #32317

merged 3 commits into from Dec 17, 2020

Conversation

quasipickle
Copy link
Contributor

@quasipickle quasipickle commented Dec 2, 2020 •
edited by XhmikosR

Add some variables to allow users to modify how much a button gets lighter or darker on :hover and :active.

Fixes #32290

@quasipickle
Variables for modifying button state colours.
537a433 
Add some variables to allow users to modify how much a button gets
lighter or darker on :hover and :active.
@quasipickle quasipickle requested a review from a team as a code owner December 2, 2020 19:00
@twbs twbs deleted a comment from quasipickle Dec 3, 2020
@twbs twbs deleted a comment from phyo6hu Dec 3, 2020
ffoodd
ffoodd approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, thanks 👍

MartijnCuppens
MartijnCuppens approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on the TODO list in my head. Thanks for reading my mind! 🧠

@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Dec 17, 2020
@XhmikosR XhmikosR moved this from Inbox to Approved in v5.0.0-beta2 Dec 17, 2020
@XhmikosR XhmikosR merged commit df763d6 into twbs:main Dec 17, 2020
v5.0.0-beta2 automation moved this from Approved to Done Dec 17, 2020
@XhmikosR XhmikosR changed the title Variables for modifying button state colours. Add variables for modifying button state colours. Dec 17, 2020
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
css feature v5
Projects
No open projects
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variables for button hover+active states
4 participants
@quasipickle @ffoodd @MartijnCuppens @XhmikosR