Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for popover example showing above navbar #32445

Merged
merged 8 commits into from Dec 18, 2020
Merged

Fix for popover example showing above navbar #32445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1a4d7f9
Fix for popover example showing above navbar
sijusamson Dec 12, 2020
2b1b1ca
Added a variable for handling popover issue
sijusamson Dec 15, 2020
4e90225
Fix for popover example showing above navbar
sijusamson Dec 12, 2020
608624a
Added a variable for handling popover issue
sijusamson Dec 15, 2020
165088b
Changed variable name specifically to documentation.
sijusamson Dec 15, 2020
70442d9
Update _variables.scss
XhmikosR Dec 16, 2020
c6b1c07
Update _variables.scss
XhmikosR Dec 16, 2020
3fd3888
Merge branch 'main' into popover-example-going-above-navbar
XhmikosR Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/assets/scss/_subnav.scss
View file
Open in desktop
@@ -1,7 +1,7 @@
.bd-subnavbar {
// The position and z-index are needed for the dropdown to stay on top of the content
position: relative;
z-index: $zindex-sticky;
z-index: $bd-navbar-zindex;
background-color: rgba($white, .95);
box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05), inset 0 -1px 0 rgba(0, 0, 0, .15);

Expand Down
3 changes: 3 additions & 0 deletions site/assets/scss/_variables.scss
View file
Open in desktop
Expand Up @@ -11,3 +11,6 @@ $bd-warning: #f0ad4e;
$bd-danger: #d9534f;
$dropdown-active-icon: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 8 8'><path fill='#292b2c' d='M2.3 6.73L.6 4.53c-.4-1.04.46-1.4 1.1-.8l1.1 1.4 3.4-3.8c.6-.63 1.6-.27 1.2.7l-4 4.6c-.43.5-.8.4-1.1.1z'/></svg>");
$sidebar-collapse-icon: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16'><path fill='none' stroke='rgba(0,0,0,.5)' stroke-linecap='round' stroke-linejoin='round' stroke-width='2' d='M5 14l6-6-6-6'/></svg>");

// Higher than core's $zindex-tooltip, which is 1070
$bd-navbar-zindex: 1080;