Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homepage-hero.svg redundant path #32617

Closed
wants to merge 3 commits into from
Closed

homepage-hero.svg redundant path #32617

wants to merge 3 commits into from

Conversation

arthurshlain
Copy link

@arthurshlain arthurshlain commented Dec 26, 2020

Redundant pixelated outline path of letter B removed.

image
image

Redurdant pixelated outline path of letter B removed
@XhmikosR XhmikosR requested a review from mdo December 28, 2020 06:10
@twbs twbs deleted a comment from arthurshlain Dec 29, 2020
@patrickhlauke
Copy link
Member

for the hero image itself, it's probably not that important, but note that just removing the extra path/outline makes the B slightly thinner (animation here to show the difference)

animation showing the hero image with and without the extra outline path

@mdo
Copy link
Member

mdo commented Jan 5, 2021

The path is intentional given the gradient inside the B—it provides a slight highlight. If you have tips for improving how it's rendered, I'm all ears! Otherwise, we'll leave it as-is :).

@mdo mdo closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants