Remove redundant modal-open class from modal.js

[GeoSot]

As scrollbar.js handles body overflowY, it is useless to use an extra class for the same reason

Based on this PR #33551

[alpadev]

I guess you can close #33551 then since that is covered by this PR as well.

[GeoSot]

I guess you can close #33551 then since that is covered by this PR as well.

Thank you for your quick review. 😄
You are right, I was hoping to push them one by one, getting first the css-review approval.

[marco-amorim]

even tho it's redundant, you can also look at it like it's more information for the person developing the application, so they can easily see what exactly is overriding the default scrolling behavior of the body.

[GeoSot]

@marco-amorim , as modal, and offcanvas, uses same pieces of code, and both are going to accept different rootElements than body, do you have any proposals which js helper should handle this (scrollbar or backdrop)? (Offcanvas doesn't provide any information till now)

[mdo]

I missed that this was removing a class... might be a breaking change if folks have built off that at this point. Thoughts?

see above

[GeoSot]

reverted the 'breaking' change, moving the class toggling functionality to backdrop.js

As an alternative, there is #33551 too that removes only the redundant css.