Docs offcanvas navbar #34487
Merged
Docs offcanvas navbar #34487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
docs-offcanvas-navbar
branch
from
3c9a521
to
72e79d0
Compare
XhmikosR
reviewed
Jul 21, 2021
XhmikosR
reviewed
Jul 21, 2021
mdo
force-pushed
the
docs-offcanvas-navbar
branch
from
71c139e
to
af93efb
Compare
ffoodd
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
LGTM!
We seem to use 1.25rem a lot indeed, setting a new variable might help a bit.
Regarding docs sidebar, I don't think it should be using offcanvas. Having two different navs help in identifying them , IMHO. But that's more a UX decision, my opinion might not have much value :D
The PR is looking fine as-is, and is working fine AFAIC.
Opted not to do a CSS variable here since on .bd-content it would be inherited into our examples
mdo
force-pushed
the
docs-offcanvas-navbar
branch
from
f44fb00
to
9d659ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to update our docs navbar for v5.2.0 to use the offcanvas navbar styles.
Preview: https://deploy-preview-34487--twbs-bootstrap.netlify.app/