Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a template factory helper to handle all template cases #34519

Merged
merged 8 commits into from
Nov 25, 2021
Merged

Add a template factory helper to handle all template cases #34519

merged 8 commits into from
Nov 25, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jul 16, 2021 •
edited
Loading

Extract code tooltip/popover to a different class (templateFactory) helper to handle their needs, and simplify them

In future, can be used on #34043 , on alerts & toasts templates on site code

preview

TODO:

  • Documentation
  • Ignore the intended innerHTML uses LGTM errors
  • Adjust bundlewatch limits before the final merge (XhmikosR)

fixes #35375

@GeoSot GeoSot force-pushed the gs-make-template_factory branch 8 times, most recently from 69ab394 to 0303338 Compare July 24, 2021 14:35
@GeoSot GeoSot marked this pull request as ready for review July 26, 2021 10:44
@GeoSot GeoSot requested a review from a team as a code owner July 26, 2021 10:44
@GeoSot GeoSot added this to In progress in v5.2.0 via automation Jul 26, 2021
@GeoSot GeoSot force-pushed the gs-make-template_factory branch 3 times, most recently from 7b412ae to e7ce267 Compare July 30, 2021 00:06
@GeoSot GeoSot mentioned this pull request Jul 30, 2021
Merged
@GeoSot GeoSot requested a review from a team as a code owner August 4, 2021 11:07
@XhmikosR XhmikosR changed the title Make a template factory helper Add a template factory helper Sep 8, 2021
@GeoSot GeoSot force-pushed the gs-make-template_factory branch 3 times, most recently from 82b644d to 9502239 Compare October 5, 2021 23:18
@XhmikosR XhmikosR changed the title Add a template factory helper Add a template factory helper to handle all template cases Oct 13, 2021
@XhmikosR XhmikosR force-pushed the gs-make-template_factory branch 3 times, most recently from 3141b7e to 141fe9f Compare October 13, 2021 12:38
@XhmikosR
Copy link
Member

/CC @mdo for the doc changes.

@XhmikosR XhmikosR requested a review from mdo October 13, 2021 12:47
@GeoSot GeoSot mentioned this pull request Nov 22, 2021
Closed
3 tasks
v5.2.0 automation moved this from Review in progress to Reviewer approved Nov 25, 2021
@XhmikosR XhmikosR merged commit 94a596f into main Nov 25, 2021
v5.2.0 automation moved this from Reviewer approved to Done Nov 25, 2021
@XhmikosR XhmikosR deleted the gs-make-template_factory branch November 25, 2021 17:14
This was referenced Nov 30, 2021
Closed
Closed
@GeoSot GeoSot mentioned this pull request Nov 30, 2021
Merged
GeoSot added a commit that referenced this pull request Nov 30, 2021
@GeoSot
remove left over method after #34519 merge
1b3f677
@XhmikosR XhmikosR mentioned this pull request Dec 7, 2021
Merged
This was referenced Feb 2, 2022
Merged
Closed
@GeoSot GeoSot mentioned this pull request May 3, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
feature js v5
Projects
No open projects
v5.2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip: this.tip.querySelector(...) is null
2 participants
@GeoSot @XhmikosR