Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement issue forms #34626

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Implement issue forms #34626

merged 1 commit into from
Sep 28, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jul 29, 2021

Put salt on our issue and MR templates, wishing to help future contributors to be descriptive

@GeoSot GeoSot requested a review from mdo July 29, 2021 23:59
@GeoSot GeoSot added the p4 Low priority, nice to have label Jul 30, 2021
@mdo
Copy link
Member

mdo commented Jul 30, 2021

What if we used issue forms instead? https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

ffoodd
ffoodd reviewed Aug 2, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ideas, I like it— but it needs an english speaker's review 😅

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
@GeoSot
Copy link
Member Author

GeoSot commented Aug 3, 2021 •
edited
Loading

I changed them to forms. Seems a better approach, but has some restrictions in styling

@mdo mdo marked this pull request as ready for review September 28, 2021 16:46
@mdo mdo force-pushed the gs-issue-templates branch 2 times, most recently from 00a4072 to 4d69200 Compare September 28, 2021 20:35
@GeoSot @XhmikosR @mdo
Change from issue templates to issue forms
9771fe4 
Co-Authored-By: XhmikosR <xhmikosr@gmail.com>
Co-Authored-By: GeoSot <geo.sotis@gmail.com>
@mdo mdo changed the title Enhance issue and merge request templates Implement issue forms Sep 28, 2021
@mdo
Copy link
Member

mdo commented Sep 28, 2021

I've removed the PR template change from this for now. Going to push forward with the issue forms though.

@mdo mdo added this to In progress in v5.1.2 via automation Sep 28, 2021
v5.1.2 automation moved this from In progress to Ready to merge Sep 28, 2021
@mdo mdo merged commit 7da7e8a into main Sep 28, 2021
@mdo mdo deleted the gs-issue-templates branch September 28, 2021 23:02
v5.1.2 automation moved this from Ready to merge to Done Sep 28, 2021
@XhmikosR XhmikosR added the meta label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd left review comments

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
meta p4 Low priority, nice to have
Projects
No open projects
v5.1.2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeoSot @mdo @ffoodd @XhmikosR