Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vnu-jar from 21.6.11 to 21.9.2 #34874

Merged
merged 6 commits into from
Sep 7, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2021

Bumps vnu-jar from 21.6.11 to 21.9.2.

Release notes

Sourced from vnu-jar's releases.

latest

c2cdd4a054360f764ff74022525e3bc457c9feff — Drop some no-longer-needed filters

Commits
  • 2022031 Roll back to latest Jetty 9 (9.4.43.v20210629)
  • be0bcb0 Revert "Add Jetty backend HTTP/2 support (clear text, h2c)"
  • f86bde2 Update css-validator
  • 956ed34 Update css-validator
  • 11e9ee1 Update Jetty to 10.0.6; javax.servlet-api to 4.0.1
  • b1dd328 Update css-validator
  • 93c88bd Update css-validator
  • f5384f4 Drop another no-longer-needed filter
  • 21ea635 Update css-validator; drop some no-longer-needed filters
  • 4d79cda Dockerfile: Bump unzip version
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vnu-jar](https://github.com/validator/validator) from 21.6.11 to 21.9.2.
- [Release notes](https://github.com/validator/validator/releases)
- [Changelog](https://github.com/validator/validator/blob/main/CHANGELOG.md)
- [Commits](validator/validator@21.6.11...21.9.2)

---
updated-dependencies:
- dependency-name: vnu-jar
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@XhmikosR
Copy link
Member

XhmikosR commented Sep 2, 2021

@patrickhlauke should we just ignore these errors?

@patrickhlauke
Copy link
Member

An "aria-disabled" attribute whose value is "true" should not be specified on an "a" element that has an "href" attribute. are warnings, not hard errors.

per https://www.w3.org/TR/html-aria/#docconformance

It is NOT RECOMMENDED to use aria-disabled="true" on an a element with an href attribute.

NOTE
If a link needs to be "disabled", remove the href attribute.

to be cleaner though, it may actually be better to do what the recommendation there is an remove the href and the aria-disabled="true" altogether. but it's not a hard failure either way

@XhmikosR
Copy link
Member

XhmikosR commented Sep 2, 2021

I'm not sure if we should remove the href attribute in all of those cases, though. That's why I was leading towards to just disabling the error 😛

But if you or anyone else wants to take a stab at it and see it in action, fine by me!

@patrickhlauke
Copy link
Member

ah, i only looked at a few (where the intent in the docs was clearly to show disabled styling). i think we should do both - set to ignore the warning, but also go through docs example usage of links with aria-disabled="true" to see if they shouldn't just be neutralised and turned into <a> elements without href altogether

@XhmikosR
Copy link
Member

XhmikosR commented Sep 2, 2021

@patrickhlauke if you are up to make a PR we'll need to backport this.

@patrickhlauke
Copy link
Member

for how long will we be backporting doc tweaks to v4? (to be clear, that PR #34886 still needs this check disabled in vnu, as we do give at least one less-than-ideal example that would fail validation)

@XhmikosR
Copy link
Member

XhmikosR commented Sep 6, 2021

We will be supporting v4-dev for some more time for sure. Not sure for how much exactly at this point, though.

I don't mind disabling the check, although we won't catch any other cases if we disable the rule. Just pointing it out :)

@patrickhlauke
Copy link
Member

I don't mind disabling the check, although we won't catch any other cases if we disable the rule. Just pointing it out :)

but again, we need it disabled because we have a non-ideal example or two (but only a warning, not a hard error) in the docs, even after #34886 is merged) - to show that yes, this can be done, and then explain to the reader the better alternatives

@XhmikosR
Copy link
Member

XhmikosR commented Sep 6, 2021

I know, I meant it mostly that we wouldn't notice any further cases after we ignore this :)

@XhmikosR XhmikosR requested a review from a team as a code owner September 6, 2021 19:22
@XhmikosR
Copy link
Member

XhmikosR commented Sep 6, 2021

I disabled it, feel free to edit the JS file to add a comment for future reference :)

@XhmikosR XhmikosR added this to In progress in v5.1.1 via automation Sep 6, 2021
@XhmikosR
Copy link
Member

XhmikosR commented Sep 6, 2021

BTW we can always go back to treating warnings as warnings and not errors if you think that's better @patrickhlauke. Otherwise please have a look an maybe add a comment about the new suppression, otherwise we can land this :)

@patrickhlauke
Copy link
Member

maybe add a comment about the new suppression

done

v5.1.1 automation moved this from In progress to Reviewer approved Sep 7, 2021
@XhmikosR XhmikosR merged commit b6855ae into main Sep 7, 2021
v5.1.1 automation moved this from Reviewer approved to Done Sep 7, 2021
@XhmikosR XhmikosR deleted the dependabot/npm_and_yarn/vnu-jar-21.9.2 branch September 7, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.1.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants