Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled link cleanup #34886

Merged
merged 6 commits into from
Sep 6, 2021
Merged

Disabled link cleanup #34886

merged 6 commits into from
Sep 6, 2021

Commits on Sep 2, 2021

  1. Disabled link cleanup

    per https://www.w3.org/TR/html-aria/#docconformance
    
    > It is NOT RECOMMENDED to use `aria-disabled="true"` on an `a` element with an `href` attribute.
    >
    >NOTE
    >If a link needs to be "disabled", remove the `href` attribute.
    
    This PR removes the unnecessary `href="#"`, `tabindex="-1"`, and `aria-disabled="true"` from disabled links in both docs pages and examples. `aria-disabled="true"` *is* kept for disabled link-based buttons (that have `role="button"`) as there it's appropriate to use (you *want* to convey to assistive technologies that this thing you're claiming is a button is also disabled at the moment)
    
    Further, the PR extends the "Link functionality caveat" to show the "proper" way (removing `href` and adding `.disabled` class only) to disable a link, but then explains what to do if that's not possible (and then keeps an example with all the traditional `href="#" tabindex="-1" aria-disabled="true"`, but explains clearly that it's not ideal). Same sort of explanation is also added to the pointer event utilities page
    patrickhlauke committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    4a60bd6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c97ed3d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Configuration menu
    Copy the full SHA
    c450f4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    639bd8b View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-authored-by: Mark Otto <markd.otto@gmail.com>
    patrickhlauke and mdo committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    4055a26 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b2fcf2 View commit details
    Browse the repository at this point in the history