Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color and border-color CSS variables to tables #35055

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Sep 26, 2021

Fixes #34944

Hi, I do not know much about CSS variables. I took the aforementioned issue as a chance to improve my knowledge. Hope that this PR would actually help

@tagliala tagliala requested a review from a team as a code owner September 26, 2021 08:46
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a couple tweaks for how we order things.

scss/_tables.scss Outdated Show resolved Hide resolved
scss/mixins/_table-variants.scss Outdated Show resolved Hide resolved
@mdo mdo added this to In progress in v5.2.0 via automation Oct 7, 2021
@tagliala tagliala force-pushed the bugfix/add-missing-css-variables-34944 branch from 3c27362 to c3619db Compare October 7, 2021 08:14
@tagliala tagliala requested a review from mdo October 7, 2021 11:27
v5.2.0 automation moved this from In progress to Reviewer approved Oct 7, 2021
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@XhmikosR XhmikosR changed the title Add color and border-color css variables to table Add color and border-color CSSvariables to tables Oct 11, 2021
@XhmikosR XhmikosR changed the title Add color and border-color CSSvariables to tables Add color and border-color CSS variables to tables Oct 11, 2021
@XhmikosR XhmikosR merged commit 5b124f6 into twbs:main Oct 11, 2021
v5.2.0 automation moved this from Reviewer approved to Done Oct 11, 2021
@tagliala tagliala deleted the bugfix/add-missing-css-variables-34944 branch October 11, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

CSS variables for $table-color and $table-border-color are missing
4 participants