Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thicker border on table thead elements #35908

Merged
merged 2 commits into from Feb 28, 2022
Merged

Remove thicker border on table thead elements #35908

merged 2 commits into from Feb 28, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented Feb 25, 2022

Use the new .table-group-divider to create your own dividers as desired. Would love to find a better way to handle border-color for this, but for now, this is at least opt-in.

I've applied it by default in another way for our docs tables to help differentiate our content vs our components.

Fixes #35342.


Also you'll notice the new calc() function, which is in preparation for more CSS vars here.

@mdo mdo added this to In progress in v5.2.0 via automation Feb 25, 2022
@mdo mdo requested a review from a team as a code owner February 25, 2022 21:59
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I think it needs some highlight for the release, since existing tables will loose their current dividers and need to "opt-in back" with .table-group-divider.

v5.2.0 automation moved this from In progress to Reviewer approved Feb 28, 2022
Use the new .table-group-divider to create your own dividers as desired. Would love to find a better way to handle border-color for this, but for now, this is at least opt-in.

I've applied it by default in another way for our docs tables to help differentiate our content vs our components.

Fixes #35342
@mdo
Copy link
Member Author

mdo commented Feb 28, 2022

Adding the release-highlight label and added it to the migration guide.

@mdo mdo merged commit e35980d into main Feb 28, 2022
v5.2.0 automation moved this from Reviewer approved to Done Feb 28, 2022
@mdo mdo deleted the table-group-divider branch February 28, 2022 19:21
@ffoodd ffoodd mentioned this pull request Mar 30, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Option to remove the thick bottom border from thead and top border from tfoot in table element
2 participants