Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the "Added in" badges in the docs #35980

Merged
merged 3 commits into from Mar 11, 2022
Merged

Redesign the "Added in" badges in the docs #35980

merged 3 commits into from Mar 11, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 9, 2022

Cherry-picked from #35736. /cc @XhmikosR

@mdo mdo added this to In progress in v5.2.0 via automation Mar 9, 2022
@XhmikosR
Copy link
Member

XhmikosR commented Mar 9, 2022

This needs to land after #35979 since that's where fw-semibold is added. Other than that, LGTM!

@WinterSilence
Copy link
Contributor

WinterSilence commented Mar 11, 2022

extract duplicate labels <small class="d-inline-flex px-2 py-1 fw-semibold text-success bg-success bg-opacity-10 rounded-2">Added in v...</small> into /site/layouts/shortcodes/:

{{- /*
  Usage: `since version`

*/ -}}

{{- $version := .Get "version" | default $.Site.version -}}

<small class="d-inline-flex px-2 py-1 fw-semibold text-success bg-success bg-opacity-10 rounded-2">Added in v{{ $version }}</small>

@XhmikosR
Copy link
Member

@WinterSilence thanks, but I think it'd be better if you made a PR later after this has landed.

v5.2.0 automation moved this from In progress to Reviewer approved Mar 11, 2022
@XhmikosR XhmikosR merged commit d16088d into main Mar 11, 2022
v5.2.0 automation moved this from Reviewer approved to Done Mar 11, 2022
@XhmikosR XhmikosR deleted the redesign-added-in branch March 11, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants