Fix button hover color in cover example #37123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hovering the button on the Cover example makes the text white, making it impossible to read on the white background.
This is due to the use of
.btn-secondaryclass (which appliescolor: var(--bs-btn-hover-color)aka#fffon hover) together with the use of.bg-whiteclass.This PR fix this issue. I decided to simply switch from
.btn-secondaryto the.btn-lightclass, since it is the closest thing to a white button that we have at the moment.Thus, this class changes the button text on hover to black, providing also a nice transition effect (from
#333to#000) that did not exist before.