Fix disabled floating labels color #37408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
force-pushed
the
main-jd-fix-form-floating-disabled-colour
branch
from
70f1df2
to
6fd1241
Compare
julien-deramond
force-pushed
the
main-jd-fix-form-floating-disabled-colour
branch
from
6fd1241
to
ca68922
Compare
mdo
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #37362
Description
This PR adds a new Sass var called
$form-floating-label-disabled-colorthat will be used to display the label when form floating labels are disabled.For the selects, it is consistent with Select > Disabled.
For the floating labels (without values), we risk to confuse the label with a simple input and its value but I don't see how to do it differently.
Type of changes
Checklist
npm run lint)Live previews