Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove git credentials after checkout #37459

Merged
merged 2 commits into from
Nov 9, 2022
Merged

CI: remove git credentials after checkout #37459

merged 2 commits into from
Nov 9, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Nov 9, 2022

Mostly as a security precaution and assuming everything is still passing.

@XhmikosR XhmikosR added the CI label Nov 9, 2022
@XhmikosR XhmikosR marked this pull request as ready for review November 9, 2022 06:53
julien-deramond
julien-deramond approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising that persist-credentials: false is not the default value.

@XhmikosR XhmikosR merged commit 11f5d28 into main Nov 9, 2022
@XhmikosR XhmikosR deleted the xmr/ci-creds branch November 9, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
CI
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @julien-deramond